Skip to content

Conversation

@vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Mar 9, 2025

Follow up to #130379.

Created using spr 1.3.4
@llvmbot llvmbot added the llvm:ir label Mar 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 9, 2025

@llvm/pr-subscribers-llvm-ir

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/130448.diff

1 Files Affected:

  • (modified) llvm/include/llvm/IR/ModuleSummaryIndexYAML.h (+2-2)
diff --git a/llvm/include/llvm/IR/ModuleSummaryIndexYAML.h b/llvm/include/llvm/IR/ModuleSummaryIndexYAML.h
index adcd17783d6c0..b662013d1f998 100644
--- a/llvm/include/llvm/IR/ModuleSummaryIndexYAML.h
+++ b/llvm/include/llvm/IR/ModuleSummaryIndexYAML.h
@@ -349,11 +349,11 @@ template <> struct MappingTraits<ModuleSummaryIndex> {
     if (io.outputting()) {
       std::vector<StringRef> CfiFunctionDefs(index.CfiFunctionDefs.begin(),
                                              index.CfiFunctionDefs.end());
-      std::sort(CfiFunctionDefs.begin(), CfiFunctionDefs.end());
+      llvm::sort(CfiFunctionDefs);
       io.mapOptional("CfiFunctionDefs", CfiFunctionDefs);
       std::vector<StringRef> CfiFunctionDecls(index.CfiFunctionDecls.begin(),
                                               index.CfiFunctionDecls.end());
-      std::sort(CfiFunctionDecls.begin(), CfiFunctionDecls.end());
+      llvm::sort(CfiFunctionDecls);
       io.mapOptional("CfiFunctionDecls", CfiFunctionDecls);
     } else {
       std::vector<std::string> CfiFunctionDefs;

@vitalybuka vitalybuka added the skip-precommit-approval PR for CI feedback, not intended for review label Mar 9, 2025
@vitalybuka vitalybuka merged commit 3a0d0c6 into main Mar 9, 2025
9 of 14 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcyaml-switch-stdsort-to-llvmsort branch March 9, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:ir skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants